feat(attributes): Add cache.write attribute#292
Merged
Conversation
Indicates whether a cache operation resulted in a write to the cache. Always true for unconditional writes (put, remove, clear); reflects the actual outcome for conditional operations (putIfAbsent, replace) where the write may or may not occur depending on cache state. Co-Authored-By: Claude <noreply@anthropic.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
adinauer
requested review from
a team,
Lms24,
cleptric,
lcian,
mjq and
nsdeschenes
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Member
|
I think you need to rerun |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
Bugbot Autofix prepared a fix for the issue found in the latest run.
Or push these changes by commenting: Preview (4bb83ceff8)diff --git a/javascript/sentry-conventions/src/attributes.ts b/javascript/sentry-conventions/src/attributes.ts
--- a/javascript/sentry-conventions/src/attributes.ts
+++ b/javascript/sentry-conventions/src/attributes.ts
@@ -10048,6 +10048,7 @@
[CACHE_ITEM_SIZE]: 'integer',
[CACHE_KEY]: 'string[]',
[CACHE_OPERATION]: 'string',
+ [CACHE_WRITE]: 'boolean',
[CACHE_TTL]: 'integer',
[CHANNEL]: 'string',
[CLIENT_ADDRESS]: 'string',
@@ -10524,6 +10525,7 @@
| typeof CACHE_ITEM_SIZE
| typeof CACHE_KEY
| typeof CACHE_OPERATION
+ | typeof CACHE_WRITE
| typeof CACHE_TTL
| typeof CHANNEL
| typeof CLIENT_ADDRESSThis Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard. |
Replace hardcoded version 0.5.0 with 'next' so the version gets assigned automatically during the release process. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
cache.writeboolean attribute indicating whether a cache operation resulted in a write to the cache.Always
truefor unconditional writes (put,remove,clear); reflects the actual outcome for conditional operations likeputIfAbsent,replace, andgetAndReplacewhere the write may or may not occur depending on cache state.This attribute complements the existing
cache.hitattribute for read operations and is currently set by the sentry-java SDK's Spring Cache and JCache integrations.